Skip to content

FEAT: change SizeConstraint ignoreSize defualt to true - #1259

Open
6a209 wants to merge 1 commit into
fluttercandies:mainfrom
6a209:feat/default_size
Open

FEAT: change SizeConstraint ignoreSize defualt to true#1259
6a209 wants to merge 1 commit into
fluttercandies:mainfrom
6a209:feat/default_size

Conversation

@6a209

@6a209 6a209 commented Jan 21, 2025

Copy link
Copy Markdown

The expression "0 < width < 100000" has the same effect as "ignoreSize = true" but adding these two conditions in SQL might degrade performance somewhat.

@AlexV525

Copy link
Copy Markdown
Member

Changing the flag would be a breaking change for users who wrote a valid condition but didn't toggled the flag before.

@6a209

6a209 commented Feb 4, 2025

Copy link
Copy Markdown
Author

But it originally felt like there was wrong, the default value theory should be unconditional, which would be more reasonable. However, a condition (0 < width < 100000) was added by default. If I really have an image larger than 100000, wouldn't it fail to be filtered out? I think this is not the expected behavior of the user. But then again, 100000 is really too large, almost non-existent such big images, and if such an image were to be loaded into memory all at once, it would definitely cause outofmemory,

@AlexV525

Copy link
Copy Markdown
Member

But it originally felt like there was wrong, the default value theory should be unconditional, which would be more reasonable.

If we could convert 100000 to null, that would be more reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants